docs.nestjs.com icon indicating copy to clipboard operation
docs.nestjs.com copied to clipboard

fix(): update advertising banner css style

Open Tony133 opened this issue 2 years ago • 3 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/docs.nestjs.com/blob/master/CONTRIBUTING.md

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Docs
  • [x] Other... Please describe:

What is the current behavior?

Issue Number:

  • https://github.com/nestjs/docs.nestjs.com/issues/2869
  • https://github.com/nestjs/docs.nestjs.com/issues/2921
  • https://github.com/nestjs/docs.nestjs.com/issues/2941

What is the new behavior?

Proposal:

  • Update advertising banner css style

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

Before:

screen-before-advertising-banner

After ( with fix ):

screen-fix-ok screen-fix

Tony133 avatar Dec 15 '23 22:12 Tony133

Link for preview: https://deploy-preview-2922--docs-nestjs.netlify.app/techniques/database 🔥

Tony133 avatar Dec 15 '23 22:12 Tony133

@smith558 other solutions are always accepted, if you have another solution please post it here.

Tony133 avatar Feb 28 '24 17:02 Tony133

@smith558 other solutions are always accepted, if you have another solution please post it here.

Unfortunately I do not have time currently. But I am just saying. This proposed way of fix would lead to very much decreased income from the Carbon ads placed on the website because they track "impressions".

smith558 avatar Feb 28 '24 17:02 smith558