docs.nestjs.com icon indicating copy to clipboard operation
docs.nestjs.com copied to clipboard

docs: update edge case for ConfigModule

Open PhearZero opened this issue 2 years ago • 1 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/docs.nestjs.com/blob/master/CONTRIBUTING.md

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [x] Docs
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

PhearZero avatar Aug 09 '23 19:08 PhearZero

I wonder if we should use --env-file flag in this case instead

kamilmysliwiec avatar Oct 18 '24 11:10 kamilmysliwiec

yeah, having to import dotenv ourselves seems odd.

micalevisk avatar Oct 28 '24 14:10 micalevisk

To make things simpler, we might expose the --env-file flag on the nest start command and just pass it down to node (instead of forcing everyone to use --exec etc)

kamilmysliwiec avatar Oct 28 '24 15:10 kamilmysliwiec

It's only a few more months before Node 18 hits end of life, feel free to close the ticket in favor of a --env-file pass-through

PhearZero avatar Oct 28 '24 21:10 PhearZero

https://github.com/nestjs/nest-cli/pull/2818

kamilmysliwiec avatar Nov 25 '24 11:11 kamilmysliwiec