docs.nestjs.com icon indicating copy to clipboard operation
docs.nestjs.com copied to clipboard

Published 20 hours ago • verified publisher icon nestjs

docs(openapi): prefer lazy over eager creation of the document

Open H4ad opened this issue 2 years ago • 3 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/docs.nestjs.com/blob/master/CONTRIBUTING.md

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [x] Docs
  • [ ] Other... Please describe:

What is the current behavior?

NestJS does not use the new feature of lazy initialization of Swagger, which adds some time to startup.

Associated with https://github.com/nestjs/swagger/pull/2392

What is the new behavior?

Now, by default, we use always the lazy initialization in favor of the initialization speed.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

H4ad avatar Apr 17 '23 16:04 H4ad

This linked PR:https://github.com/nestjs/swagger/pull/2392 is associated with this one and has been merged, so I would say merge this as well, right?

Tony133 avatar Jun 18 '23 22:06 Tony133

I guess we can merge this now :smile_cat:

micalevisk avatar Jun 18 '23 23:06 micalevisk

@kamilmysliwiec Can we merge this PR, this change was merged a long time ago.

H4ad avatar Nov 06 '23 12:11 H4ad