azure-storage icon indicating copy to clipboard operation
azure-storage copied to clipboard

Merge Request for issue 129

Open Setitch opened this issue 4 years ago • 0 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ o] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [o ] Tests for the changes have been added (for bug fixes / features)
  • [ x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 129 https://github.com/nestjs/azure-storage/issues/129

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No
[x] Maybe

There are breaking changes in tests that i could not fix. also it adds some new features but i dont remember now as im using it already for quite time and need to do differential now

As i see in comparrison i modified the upload meta file interface (making it smaller) i think i should bring it back to way it was but add question marks to it for not requiring all of the interface properties (like in new one)

Other information

Setitch avatar Dec 05 '20 13:12 Setitch