axios icon indicating copy to clipboard operation
axios copied to clipboard

feat: exposed multipart-body axios functions

Open kpervin opened this issue 4 months ago • 3 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: #1030

What is the new behavior?

Exposed Axios Multipart Bodies methods in HttpService.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

kpervin avatar Feb 22 '24 15:02 kpervin

these new methods weren't introduced in axios v1.0.0, right? I think we need to bump the peer dependency on axios to force the newer version... but I'm not sure

https://github.com/nestjs/axios/blob/8e0ecc4db271188f98ee09080269e27fcc0013ce/package.json#L47-L50

micalevisk avatar Feb 23 '24 11:02 micalevisk

I will check. I believe the version I have is 1.6.7. I can see when they introduced these features and make that the minimum peerDependency

kpervin avatar Feb 23 '24 11:02 kpervin

@micalevisk Seems it was added into v0.27.0 in PR #4448

kpervin avatar Feb 26 '24 20:02 kpervin