nest.land icon indicating copy to clipboard operation
nest.land copied to clipboard

Published 20 hours ago • verified publisher icon nestdotland

Move from Javascript to Typescript

Open Keimeno opened this issue 4 years ago • 12 comments

Request

Since most of nestdotlands code is written in javascript, I think it would be a great idea to convert the project from javascript to typescript.

Keimeno avatar Jul 22 '20 17:07 Keimeno

@Keimeno We are only not-typescript in the website, I think it will be great to migrate, but it should not be a priority. cc @MartonDev

littledivy avatar Jul 23 '20 03:07 littledivy

This has certainly been a topic of conversation. I think we're shooting for a TS rewrite in MVP 3. 👍

t8 avatar Jul 23 '20 03:07 t8

Good idea. I want to do this to with @t8 personally

martonlederer avatar Jul 23 '20 06:07 martonlederer

I would love to contribute to this project as well. Personally, I think we should do this in MVP 3.

zorbyte avatar Jul 23 '20 07:07 zorbyte

In my opinion, Vue doesn't really fit with typescript. If we really want to use it, we should migrate to react or svelte

martonlederer avatar Jul 23 '20 07:07 martonlederer

Thats not the case with Vue 2.6. Typescript is perfectly integrated. The only annoying part is, that .vue files need to be declared, and you loose the autocompletion of props. Also a complete rewrite wouldn't make sense. Especially migrating from vue to react.

Keimeno avatar Jul 23 '20 08:07 Keimeno

A complete rewrite would not only allow us to integrate Typescript , Vuex and Yolk more easily but also fix the current issues! I'd love to contribute in this part.

littledivy avatar Jul 23 '20 10:07 littledivy

Or we can wait for the coming Vue 3, it is now in rc5😊. And I'd like to contribute to it.

HermitSun avatar Aug 02 '20 15:08 HermitSun

Yeah we should wait until Vue 3. We'd love your contribution.

martonlederer avatar Aug 02 '20 15:08 martonlederer

@HermitSun feel free to email me your discord username, and I'll send you an invite to our internal chat! It may be easier to coordinate from there.

My email: [email protected]

t8 avatar Aug 02 '20 15:08 t8

Maybe we should even build the project with nuxt then. One of the best things about npmjs.com is, that all packages are indexed by google.

Keimeno avatar Aug 02 '20 15:08 Keimeno

@Keimeno good point. We actually have some new developments regarding that 😄

CC @maximousblk

t8 avatar Aug 02 '20 15:08 t8