nest.land icon indicating copy to clipboard operation
nest.land copied to clipboard

Minor, badge rendering with README file

Open fakoua opened this issue 4 years ago • 8 comments

The readme file renders the badges in the same line with github, while nest renders the badge in two separate lines, minor but fixing it would be great. Thanks

fakoua avatar Jun 25 '20 02:06 fakoua

@fakoua thanks for letting us know. Could you attach a link and/or a screenshot so we can see what is happening?

t8 avatar Jun 25 '20 02:06 t8

@fakoua thanks for letting us know. Could you attach a link and/or a screenshot so we can see what is happening?

For example:

https://github.com/fakoua/deno_gui and https://nest.land/package/deno_gui

Please check how the badge are rendered.

Thanks

fakoua avatar Jun 25 '20 02:06 fakoua

I see. This is very interesting. If you visit Opine's module page, this does not occur. As a workaround, try formatting your README badges like Craig Morten does here: https://raw.githubusercontent.com/asos-craigmorten/opine/main/README.md

Note: Craig uses HTML elements instead of markdown.

Let me know if this helps fix your problem!

t8 avatar Jun 25 '20 02:06 t8

Hi @tbaumer22 , It is fine for Opine, but my concern is not a specific package, we need consistency between github and nest.

fakoua avatar Jun 25 '20 02:06 fakoua

Yes, you're right. I completely agree. We'll investigate a solution to this problem when we can. Until then, feel free to use Craig Morten's method above!

Thanks again for reporting this.

t8 avatar Jun 25 '20 02:06 t8

seems to be a problem with vue-markdown. it adds a <br> tag after each image.

image

maximousblk avatar Jun 28 '20 11:06 maximousblk

You can use https://github.com/bevry/projectz for maintaining the readme badges via <!-- BADGES --> inside the readme, it uses package.json:badges and other information from inside package.json to populate them.

balupton avatar Jul 23 '20 21:07 balupton

I'm afraid that our issue here has to do with the way the badges are displayed on the site and not the badge files themselves.

@MartonDev is this something that can be fixed with your experimental vue-markdown in development?

t8 avatar Jul 24 '20 01:07 t8