Unittest of dopamine synapse model
There are only manual tests of stdp_dopa_connection and they are outdated and will be removed with #774. A unittest of this synapse model is required.
@abigailm is there progress on this one?
Model should be re-created using NESTML, including tests.
@clinssen: Whats your take on @heplesser's comment? Would this kind of third-factor plasticity be currently feasible in NESTML? Thanks!
To expand a little on my comment from 1.5 years ago: If this model including tests can be built with NESTML in the near future, that would be a way to go. If not, we need to write tests for the model as is.
Me and @YounesBouhadjar will write a unit test that:
- generates random spike times: pre, post and dopa (but will also test some edge-case predefined times, such as pre and post spikes occurring at the exact same time)
- Runs a NEST simulation with three nodes and a volume transmitter with these spike times, obtain weight recording;
- Runs a Python sim with these spike times
- precise integration to the next spike (whichever of the three)
- update values w, c, n using exponential solution of the ODE
- update values c or n depending on arriving spike
- Compares Python and NEST-obtained timeseries of w
@clinssen, @YounesBouhadjar: are there any news on this?
This was pre-empted by some other projects and queries, such as #1840, a NESTML active dendrite tutorial review, and the triplet synapse. As the latter is now working and third-factor plasticity rules are next on the NESTML agenda, we expect to pick this up again within the next few weeks!
Thanks for the update and no worries. I was just going through the stale issues in the automated testing project.
Issue automatically marked stale!
@heplesser @clinssen is this issue still relevant?
@jessica-mitchell Yes. If we have a feature, we need tests for it. It think we should proceed to write the tests as pytests for NEST.
@abigailm Would you know someone who could write these tests?
Ok I just saw that there was a merged PR regarding the unit test for STDP dopamine, and a few tests that reference it, so wasnt sure if it was already dealt with
Ok I just saw that there was a merged PR regarding the unit test for STDP dopamine, and a few tests that reference it, so wasnt sure if it was already dealt with
Do you have the number of that PR? If we have test in place, we might not need more and could close this issue indeed.
I am referring to the one above, #1840
#1840 tests plain stdp, but not stdp_dopamine_synapse. I have searched through our testsuite and have not found any test for the correct dynamics of the dopamine synapse.