nest-simulator Port test_issue

There still is an issue with the Python-version, as it triggers the "assert_thread_parallel" assertion (line 207 in vp_manager.cpp). I am not sure why, @heplesser could you take a look at that?

Mar 24 '25 09:03 JanVogelsang

@JanVogelsang This one fails currently on macOS, I believe, because we skip the test when Music is not present, which confuses the result collection process. I will need to think about the skipping logic for these MPI tests once again.

It also seems that this PR contains many more files than it should. It would be good to wait with this one until we have #3450 merged.

Mar 28 '25 09:03 heplesser

Oh true, this PR now also contains changes that #3445 contains, because that fix was required for this test to work. So we have to wait until that one is merged. #3450 is not a blocker for this one. While they are related, fixing it is not required for this test to work.

Mar 28 '25 09:03 JanVogelsang

@JanVogelsang Could you review #3467? Once that is in place it should be straightforward to implement music-skipping by decorator here.

Apr 14 '25 21:04 heplesser

@heplesser I implemented the music-skipping decorator and added it to the isuee_1974 python test.

Apr 16 '25 09:04 JanVogelsang

Blocked by #3470

Apr 16 '25 10:04 JanVogelsang

@JanVogelsang This looks in principle good to me now, but I would prefer to merge #3450 first so that the change set for this PR becomes smaller, reduced to just the port of the test and the missing-music decorator.

Apr 22 '25 12:04 heplesser

@JanVogelsang This looks in principle good to me now, but I would prefer to merge #3450 first so that the change set for this PR becomes smaller, reduced to just the port of the test and the missing-music decorator.

Sorry, I meant to merge #3445 first, not #3450.

Apr 22 '25 12:04 heplesser

@heplesser Can you rerun the test-suite now that the CI issue is merged?

Apr 22 '25 17:04 JanVogelsang

@JanVogelsang This looks in principle good to me now, but I would prefer to merge #3450 first so that the change set for this PR becomes smaller, reduced to just the port of the test and the missing-music decorator.

Sorry, I meant to merge #3445 first, not #3450.

Yes, I agree. We just need Dennis to take a very quick look at #3445

Apr 22 '25 17:04 JanVogelsang

@JanVogelsang If think you need to merge master into your branch for this PR so the Ubuntu-update in master takes effect here. That should automatically trigger the CI.

Apr 23 '25 05:04 heplesser

Pull request automatically marked stale!

Aug 12 '25 08:08 github-actions[bot]

Port test_issue_1974 from SLI to Py