nest
Re-organise tripartite connectivity generation
This PR re-organises the tripartite connectivity generation to (a) allow combination with all primary connection rules and (b) support parallelization.
@HanjiaJiang Could you provide benchmarks?
@clinssen Thank you for your comments, I hope to have addressed them all.
@HanjiaJiang @jugoslavaacimovic @IiroAhokainen I have now gone through the comments on the PR and hope to have addressed all open issues. Concerning the parameter values, I am happy with any choice, as long as there is a visible effect of the astrocyte on dynamics. Please suggest the specific values to use, and I will implement them.
@IiroAhokainen I left some comments of yours as unresolved in case you want to comment on my solution. If you are happy, please click the "Resolve" button. If you should not see a resolve button, let me know and I will resolve.
@clinssen Have you had an opportunity to check if you are content with my responses to your comments?
Converted to draft because random pooling currently only works if targets are connected in order.
@IiroAhokainen @clinssen I have now fixed the problem with pooling, so the PR is ready for review again.
@HanjiaJiang Could you create a PR towards my branch that would adjust the parameters in the examples as discussed above? I think you know the pertaining example files much better :).
@IiroAhokainen @clinssen I have now fixed the problem with pooling, so the PR is ready for review again.
@HanjiaJiang Could you create a PR towards my branch that would adjust the parameters in the examples as discussed above? I think you know the pertaining example files much better :).
Yes @heplesser I will do this. Do you think I should also include the change for default delta_IP3 (to 0.0002) as well? I know I can change it in astrocyte_lr_1994.cpp but just to double check.
Yes @heplesser I will do this. Do you think I should also include the change for default delta_IP3 (to 0.0002) as well? I know I can change it in astrocyte_lr_1994.cpp but just to double check.
@HanjiaJiang Since @IiroAhokainen pointed out that the current default value makes no sense physiologically, please change the default value for delta_IP3. Please do this change in a separate commit that changes nothing else, with a commit message like "Change astrocyte_lr_1994 parameter default value for delta_IP3 to physiologically plausible value"
Parameter changes are now integrated, so the PR is complete from my side.
@clinssen @IiroAhokainen Looking forward to your re-reviews.
@IiroAhokainen If you are done with your re-review, kindly approve explicitly :).
Thank you everyone but especially @heplesser for the hard work! This is really a great achievement. :partying_face:
Thanks everyone for your hard work and dedication. It is great to see the project and the code advancing to this point. Looking forward to see it's impact on the CNS community.
