nest-simulator icon indicating copy to clipboard operation
nest-simulator copied to clipboard

Published 20 hours ago • verified publisher icon nest

Fix data race in nestkernel/per_thread_bool_indicator.cpp

Open jprotze opened this issue 11 months ago • 2 comments

jprotze avatar Feb 28 '24 14:02 jprotze

@ackurth Could you benchmark this branch on a single node with microcircuit, up to 128 threads? Just to check that the change does not introduce a performance regression.

heplesser avatar Feb 28 '24 18:02 heplesser

@ackurth Could you benchmark this branch on a single node with microcircuit, up to 128 threads? Just to check that the change does not introduce a performance regression.

Will do.

ackurth avatar Mar 01 '24 07:03 ackurth

@ackurth Could you benchmark this branch on a single node with microcircuit, up to 128 threads? Just to check that the change does not introduce a performance regression.

I compared the suggested changes to the current NEST Master, there is no performance regression in our usual benchmarks of the microcircuit model.

ackurth avatar Mar 08 '24 14:03 ackurth

@ackurth Could you benchmark this branch on a single node with microcircuit, up to 128 threads? Just to check that the change does not introduce a performance regression.

I compared the suggested changes to the current NEST Master, there is no performance regression in our usual benchmarks of the microcircuit model.

Excellent, then we can proceed. Thanks!

heplesser avatar Mar 08 '24 14:03 heplesser