nest-simulator icon indicating copy to clipboard operation
nest-simulator copied to clipboard

Move precise spike time offset from Event to Time class

Open clinssen opened this issue 3 years ago • 9 comments

Handle precise spike times by default in many places. This is done by moving the offset member from the Event to the Time class so that is always taken into account when calling Time::get_ms().

This means that plastic synapses will by default take precise spikes into account, so that the warnings added in #2137 can be removed again.

clinssen avatar May 13 '21 09:05 clinssen

Pull request automatically marked stale!

github-actions[bot] avatar Dec 15 '21 08:12 github-actions[bot]

@clinssen, all mentioned PRs are either merged or closed. Would you be so kind as to comment on the current status of this work, and maybe provide a slightly better description? – Thanks! :)

terhorstd avatar Aug 02 '22 07:08 terhorstd

@clinssen On my computer, unittests/model_node_init.sli gets stuck in your branch, while it passed on master. Does it also get stuck on your computer?

heplesser avatar Dec 02 '22 12:12 heplesser

model_node_init.sli passes, but my testsuite seems to get stuck (hanging) on regressiontests/issue-1703.py.

clinssen avatar Dec 05 '22 19:12 clinssen

Pull request automatically marked stale!

github-actions[bot] avatar Feb 04 '23 08:02 github-actions[bot]

Any updates on this PR?

JanVogelsang avatar Jul 20 '23 13:07 JanVogelsang

@JanVogelsang This is high on my agenda, but I would like to integrate deliver-events-first before starting on this. I have a very elegant idea for it.

heplesser avatar Aug 07 '23 14:08 heplesser

Any updates here?

terhorstd avatar Dec 15 '23 15:12 terhorstd

Any updates here?

No, delayed due to higher-priority efforts, but not forgotten.

heplesser avatar Dec 15 '23 21:12 heplesser