nest-simulator icon indicating copy to clipboard operation
nest-simulator copied to clipboard

Correct numerics of gif_cond_* neurons

Open heplesser opened this issue 4 years ago • 3 comments

While analysing #1097, we discovered that the numerics of the gif_cond_ neuron have slight weakness: The spike triggered current is evolved outside the ODE solver, so a constant stc value is applied during all sub-steps of a NEST time step. The stc should be updated inside the rhs function, to have exact values at each substep.

heplesser avatar Apr 29 '20 09:04 heplesser

For more details, see #1582

clinssen avatar Jun 22 '20 08:06 clinssen

Issue automatically marked stale!

github-actions[bot] avatar Sep 03 '21 08:09 github-actions[bot]

@clinssen @pnbabu Ping!

heplesser avatar Apr 22 '22 14:04 heplesser

Do we prefer the precise analytic solution to be computed inside the GSL solver inner loop? This would provide numerical precision at the expense of some more exp() calls. We can also numerically approximate this decay inside the GSL loop and replace it with precise values at the end of every timestep. In the first case, we will need to dynamically allocate the ODE state vector, as the model supports an arbitrary number of STC and SFA time constants, and these will all have to go into the state vector.

clinssen avatar Dec 01 '22 14:12 clinssen

I would argue for precision at the expense of exp() calls.

heplesser avatar Dec 01 '22 21:12 heplesser

Issue automatically marked stale!

github-actions[bot] avatar Feb 05 '23 08:02 github-actions[bot]