nessita
nessita
Hey @hrushikeshrv, thank you for restarting work on this. Specifically about the "Add" (plus sign) button: I love the new proposed location. Do you think that moving it to that...
> Hi @nessita, I tried to rebase this branch onto main, but it looks like I messed up somehow. I followed the steps you mentioned and the steps in Adam's...
> Thanks for your help @nessita, I think I've fixed it. I've also added release notes. Amazing! Please remember to update the ticket flags ("has patch") so the branch appears...
> Hi @ngnpope ready for another revision Hello @HamaBarhamou! Thank you for your continued work in this branch. I wanted to mention two things: 1. I believe that Nick asked...
I would go a different route to solve this issue, specially because I believe that the best practice for help texts is not to use markup at all (more so...
@fsbraun Would you have time to update this PR by rebasing onto main and ensuring is ready for re-review? Thanks! @django/accessibility Would you have any opinion on my proposal above?...
> @nessita I've rebased and rewritten to reflect your first comment: > > * Help texts do not contain markup or buttons > > * Widget now contains the button...
I've reviewed this work and I agree that having `settings` and `modify_settings` being static methods is both more correct and more handy. So from that POV I would certainly merge...
@ngnpope Hi and thank you for your patience. I've been thinking about this, and while I like the idea of the cleanup, I wonder how invasive it could be for...
I've continued my thinking about this and I do believe now that we should **not** remove `self.settings` nor `self.modify_settings`. I'm also convinced landing commit 1 is a good idea, but...