nessita

Results 180 comments of nessita

> > There's a change required to the way the logger is created. Also we'll need a new test to confirm the behaviour change. > > Oh and there may...

> > Hi @shangxiao, i have made the proposed changes and also tried to update the documentation in this commit. > > Thanks 🏆 The `logger` still isn't at module-level...

Hey @sulabhkatila, thank you for your continued work. If this branch is ready for a re-review, please double check that the ticket flags are properly set or unset. [This are...

@claudep Hi there! I pushed some code and docs tweaks, I think it's ready to be merged. Would you fancy doing a final review to this PR? (no worries if...

> I think people are going to be confused about what the difference is between this and the active flag on the edit screen: I started reviewing this PR and...

> @nessita Thanks for taking the time to look through this. > > Indeed, the wording has been discussed [here](https://github.com/django/django/pull/16942#discussion_r1218526204) (and I also tried to get some input [here](https://code.djangoproject.com/ticket/34429#comment:6)). >...

There is also a potentially awkward user flow when: 1. A user `tesuser1` has an unusable password 2. Later on, the admin user goes to this user's change form to...

> @nessita Indeed, I initially had the password fields enabled by default. @felixxm requested it differently here: [#16942 (comment)](https://github.com/django/django/pull/16942#discussion_r1261060471) Oh, I see. I can understand the goal of having the...

> I'll give it a try. There's an issue with postgres selenium tests which I cannot reproduce. Thanks! re: selenium, see Sarah's comment (test is flaky). I'll do another UI...

Hey Fabian, I did a UI review as promised. This is looking good! Thank you for being so responsive and open to our feedback. Before going any deeper in a...