dante icon indicating copy to clipboard operation
dante copied to clipboard

Published 20 hours ago • verified publisher icon nesquena

Major refactor

Open krainboltgreene opened this issue 10 years ago • 9 comments

So this started off as me just implementing that logger change, but ended up as a major refactor. I didn't start off with this in mind but I think it's something that'll be good for anyone using dante, with the following being the most important:

  1. No more internal logging code.
  2. No more internal PID management
  3. No more erb or yaml requirements (Not sure why they're even required?)
  4. Smaller surface to test.
  5. Easier time inheriting the core class for custom daemon classes.

Some things still left to be done:

  1. Pid file management, probably with https://github.com/samullen/pidfile
  2. User/group management
  3. Some default tests, maybe
  4. Built in stop/start/restart commands?

krainboltgreene avatar Mar 30 '14 09:03 krainboltgreene

Looks good, I wish it would be merged

Paxa avatar Aug 25 '14 04:08 Paxa

:+1:

leucos avatar Sep 14 '14 16:09 leucos

Yeah, looks nice!

bdandy avatar Oct 23 '14 11:10 bdandy

@nesquena, will you accept this pull request?

bdandy avatar Nov 04 '14 12:11 bdandy

I haven't looked at dante in a long while but sure I will merge this in, sorry it took so long. If anyone wants to help out as a contributor / maintainer for dante, I'd certainly appreciate the help.

nesquena avatar Nov 04 '14 20:11 nesquena

I now manage hamstergem/hamster, I don't mind maintaining another gem.

krainboltgreene avatar Nov 04 '14 20:11 krainboltgreene

Great, I've added you as a collaborator for dante. Appreciate you stepping in.

nesquena avatar Nov 04 '14 20:11 nesquena

Is this project alive? Any updates on the status of this PR?

mkonikowski avatar Jun 26 '15 08:06 mkonikowski

Semi-sortive? My initial goal was to revamp dante, but frankly with the advent of things like systemd it seems like dante really isn't needed.

There are better CLI frameworks (clamp, commander) and there are easier to use process management tools now (upstart, systemd, launchctl).

Frankly dante.gem is old.

On Fri, Jun 26, 2015 at 3:40 AM, Mateusz Konikowski < [email protected]> wrote:

Is this project alive? Any updates on the status of this PR?

— Reply to this email directly or view it on GitHub https://github.com/nesquena/dante/pull/12#issuecomment-115576776.

Kurtis Rainbolt-Greene, Hacker Software Developer 1631 8th St. New Orleans, LA 70115

krainboltgreene avatar Jun 27 '15 19:06 krainboltgreene