backburner icon indicating copy to clipboard operation
backburner copied to clipboard

Searching/ Canceling jobs based on id

Open lewstherin opened this issue 8 years ago • 4 comments

Had a requirement to cancel jobs that have been scheduled. Also, added the functionality to look for jobs based on id, so that we can call lower level beaneater methods on them.

Had to change the requires to require_relatives to support ruby 2.4, otherwise the tests wouldn't pass.

lewstherin avatar Mar 30 '17 13:03 lewstherin

Also, ruby 2.4.0 raises deprecation warnings for class Fixnum. Was not sure if I should fix that. Please let me know if I should fix this also.

The failing build reported above is for 1.9.3. I am guessing it has something to do with the require_relatives. Let me know if I should investigate the same.

lewstherin avatar Mar 30 '17 13:03 lewstherin

@nesquena Should we update the CI config to drop <2.0 support?

@lewstherin Thanks for the PR. I'll take a look later at it (if @nesquena doesn't first)

contentfree avatar Mar 30 '17 17:03 contentfree

@contentfree Yeah good point, we should focus on >= 2.0 now going forward

nesquena avatar Mar 31 '17 22:03 nesquena

@contentfree @nesquena Any thoughts on merging this?

lewstherin avatar Jun 25 '17 19:06 lewstherin