serverless-cljs-plugin icon indicating copy to clipboard operation
serverless-cljs-plugin copied to clipboard

Cljs plugin does not exclude dev dependencies

Open arichiardi opened this issue 8 years ago • 4 comments

I have run against this problem a couple of times now and this I have decided to investigate.

So given that we are not using the zipService provided by the Serverless Framework to zip up our stuff we don't mimic (I guess by design) its standard behavior. That's unfortunate.

There are two solutions to this (but maybe more, open to suggestions):

  • Make so that we use the zipService above in index.js and then both lumo and lein would just reopen and append to the zip file.
  • Reimplement the same behavior in both plugins.

I think option one is more work but also probably the right thing to do, but I am also wondering if there is a way not to skip the packaging step (just provide a custom zip name to it).

Any other idea?

arichiardi avatar Oct 06 '17 02:10 arichiardi

I actually see that if the compiler just does its job of copying the files in the root of the project, Serverless will just pick it up and zip itself. So my question is now, what am I missing? Why is this plugin doing the zipping?

arichiardi avatar Oct 06 '17 02:10 arichiardi

Ok so I think I found out why, PR coming.

arichiardi avatar Oct 06 '17 03:10 arichiardi

Any update on this? I am seeing this issue today. @arichiardi

ckirkendall avatar Aug 31 '18 20:08 ckirkendall

@ckirkendall I thought I fixed this? Cannot recall now

arichiardi avatar Sep 07 '18 16:09 arichiardi