ckb icon indicating copy to clipboard operation
ckb copied to clipboard

refactor compression module and add `Lz4` compression method

Open Guocork opened this issue 9 months ago • 4 comments

What problem does this PR solve?

Issue Number: #4786

Problem Summary: support Lz4 compress methods.

What is changed and how it works?

refactor compression moudle and add Lz4 compression method

Check List

Tests

  • Unit test

Release note

Title Only: Include only the PR title in the release note.

Guocork avatar Jul 10 '25 08:07 Guocork

Thank you for your contribution, but unfortunately, this PR will not be merged due to the following reasons:

  1. Although lz4's decompression capability is an order of magnitude higher than snappy's, its compression performance is similar, so overall the benefits are not high.
  2. Enabling multiple compression algorithms in the network module requires a complex process: from tentacle support to ckb full implementation, for the time being, there is no particularly strong impetus
  3. The bind implementation of lz4 does not support wasm yet, and a feature isolation process is required

driftluo avatar Jul 10 '25 10:07 driftluo

Thank you for your contribution, but unfortunately, this PR will not be merged due to the following reasons:

  1. Although lz4's decompression capability is an order of magnitude higher than snappy's, its compression performance is similar, so overall the benefits are not high.
  2. Enabling multiple compression algorithms in the network module requires a complex process: from tentacle support to ckb full implementation, for the time being, there is no particularly strong impetus
  3. The bind implementation of lz4 does not support wasm yet, and a feature isolation process is required

Got it, thank you for your review and response.I'm interested in this project, but I noticed that there aren't many issues currently open in the CKB repository. Are there any issues I could contribute to?

Guocork avatar Jul 11 '25 02:07 Guocork

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Aug 26 '25 02:08 github-actions[bot]

Thank you for your contribution, but unfortunately, this PR will not be merged due to the following reasons:

  1. Although lz4's decompression capability is an order of magnitude higher than snappy's, its compression performance is similar, so overall the benefits are not high.
  2. Enabling multiple compression algorithms in the network module requires a complex process: from tentacle support to ckb full implementation, for the time being, there is no particularly strong impetus
  3. The bind implementation of lz4 does not support wasm yet, and a feature isolation process is required

Got it, thank you for your review and response.I'm interested in this project, but I noticed that there aren't many issues currently open in the CKB repository. Are there any issues I could contribute to?

Hi @Guocork, thanks a lot for taking the time to contribute! 🙌

We used to have a bot that automatically closed inactive issues, but we realized that this isn’t ideal for an open-source project — it makes it harder for newcomers to discover issues they can work on.

So we removed the bot: https://github.com/nervosnetwork/ckb/pull/4943

I’ve also reopened some of those stale issues. You’ll find a few labeled good-for-first that could be a nice starting point: https://github.com/nervosnetwork/ckb/issues?q=is%3Aissue%20state%3Aopen%20label%3Astale

(Some of them might already be outdated, so feel free to ask questions or point it out if something doesn’t look right.)

Really glad to have you here, and looking forward to more of your contributions! 🚀

chenyukang avatar Aug 31 '25 04:08 chenyukang