ckb icon indicating copy to clipboard operation
ckb copied to clipboard

Prevent `ckb-shared` import `ckb-db-schema`

Open eval-exec opened this issue 1 year ago • 1 comments

What problem does this PR solve?

Problem Summary:

I believe that loading the COLUMN_NUMBER_HASH data in ckb-shared is not appropriate; it should be moved to ckb-store.

What is changed and how it works?

Related changes

  • [x] Move loading the COLUMN_NUMBER_HASH data function from ckb-shared to ckb-store
  • [ ] Move loading the COLUMN_BLOCK_BODY data function from ckb-shared to ckb-store

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note

Title Only: Include only the PR title in the release note.

eval-exec avatar Jul 17 '24 05:07 eval-exec

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Dec 05 '24 02:12 github-actions[bot]