angular-file-upload icon indicating copy to clipboard operation
angular-file-upload copied to clipboard

Published 20 hours ago • verified publisher icon nervgh

Fixed: "onDragLeave is not working" (#719)

Open rreddyNg opened this issue 8 years ago • 4 comments

Fixes Issue #719

rreddyNg avatar Feb 15 '17 22:02 rreddyNg

Any plans to merge it soon? We are looking forward to have this PR integrated. Really.

yhnavein avatar Oct 04 '17 08:10 yhnavein

This is quite similar with #643. @yhnavein Have you tested it? Does it works?

nervgh avatar Oct 07 '17 04:10 nervgh

Yes, we are using it in our main application for few months so far. No issues here with this PR

07.10.2017 06:42 "Alex" [email protected] napisał(a):

This is quite similar to #643 https://github.com/nervgh/angular-file-upload/pull/643. @yhnavein https://github.com/yhnavein Have you tested it? Does it works?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nervgh/angular-file-upload/pull/720#issuecomment-334910148, or mute the thread https://github.com/notifications/unsubscribe-auth/AAfiZf8PpYl4ekwvZ6ZCKpkWBKHZ9SSNks5spwE6gaJpZM4MCUJF .

yhnavein avatar Oct 07 '17 08:10 yhnavein

This solution is overcomplicated and doesn't fully fix the problem. Cancelling of the timeout must be added into onDragOver as well, otherwise flickering effect keeps appearing, just rarer.

That fix is much more clear and fully solves the issue: https://github.com/nervgh/angular-file-upload/pull/643

Stalinko avatar Jan 08 '18 09:01 Stalinko