elasticsearch icon indicating copy to clipboard operation
elasticsearch copied to clipboard

Allow to use HTTPS

Open kcampion opened this issue 11 years ago • 4 comments

I updated source code to allow using HTTPS. I'm on the right way?

https://github.com/kcampion/elasticsearch/commit/f0be154d18c20dbf3de8e4eb2bdf48f547095ff1

kcampion avatar Jun 04 '14 00:06 kcampion

Yes, that approach should work. A bit strange to reuse the HTTP transport, and it requires you to add another constructor param to it. Its probably better to just extend it and change only the protocol part.

nervetattoo avatar Jun 04 '14 18:06 nervetattoo

Yes, but HTTP is already extend with Base. What was your idea?

kcampion avatar Sep 06 '14 04:09 kcampion

will we see HTTPs support as a feature soon?

timomayer avatar Jan 27 '15 07:01 timomayer

Yes, I have a thought @kcampion

$client = Client::connection(array(
  ...
  'secure' => true
));

Then each transport can infer what secure actually means in implementation.

nervetattoo avatar Jan 27 '15 08:01 nervetattoo