elasticsearch
elasticsearch copied to clipboard
Allow to use HTTPS
I updated source code to allow using HTTPS. I'm on the right way?
https://github.com/kcampion/elasticsearch/commit/f0be154d18c20dbf3de8e4eb2bdf48f547095ff1
Yes, that approach should work. A bit strange to reuse the HTTP transport, and it requires you to add another constructor param to it. Its probably better to just extend it and change only the protocol part.
Yes, but HTTP is already extend with Base. What was your idea?
will we see HTTPs support as a feature soon?
Yes, I have a thought @kcampion
$client = Client::connection(array(
...
'secure' => true
));
Then each transport can infer what secure actually means in implementation.