ring_logger icon indicating copy to clipboard operation
ring_logger copied to clipboard

Persist logs on terminate if appropriate.

Open taun-fellowes opened this issue 1 year ago • 1 comments

If the logs are being persisted periodically, then it would also be useful if they are persisted as part of a terminate event to avoid losing logs to a Nerves.Runtime.reboot/0.

taun-fellowes avatar Sep 11 '24 16:09 taun-fellowes

Hi @taun-fellowes! Thanks for the PR. It makes sense to me.

Would it be possible to add a small unit test?

Also, don't worry about CI failures on Elixir 1.11 or 1.12. I need to make a pass at updating this project for Elixir 1.17. I assume it will be a trivial update since I know Elixir 1.17 works fine, but a side effect will removing support for those older versions.

fhunleth avatar Sep 12 '24 13:09 fhunleth

Thanks! Also, a unit test is coming in the next commit.

fhunleth avatar Jan 28 '25 14:01 fhunleth