David Tsiklauri

Results 64 comments of David Tsiklauri

For some reason, `:data => { :turbo => { :frame => "pagination"` doesn't work. Turbo frame still behaves according to `target="_top"` and refreshes whole page instead of just updating `turbo-frame`...

With the current solution, back-end side still renders a whole page including header and other elements, that won't be updated (see screenshot). For example, generating a header requires ~1s extra...

@AntonKhorev Yes. Should I create a separate PR in the https://github.com/openstreetmap/leaflet-osm for it?

I created a PR for the [leaflet-osm](https://github.com/openstreetmap/leaflet-osm) (https://github.com/openstreetmap/leaflet-osm/pull/38) that needs to be merged before this PR will be, as asynchronous loading part depends on it.

This PR is linked to the https://github.com/openstreetmap/leaflet-osm/pull/38. If leaflet-osm PR is not merged, this PR can't be merged.

PR was updated to include changes made in the https://github.com/openstreetmap/leaflet-osm/pull/38. As leaflet-osm PR is now merged, this PR can be reviewed and merged.

@AntonKhorev I couldn't reproduce JS errors in the console. But I changed logic and now when user clicks "Map Data" checkbox, previous action is skipped immediately. Therefore, there will be...

If there are no other change requests for this PR, I'll create a new PR for the [leaflet-osm](https://github.com/openstreetmap/leaflet-osm) to merge changes done in the `vendor/assets/leaflet/leaflet.osm.js`.

PR was updated. Branch was synced with master and conflicts were resolved. Also, instead of handling canceling layer loading in the `setTimeout` callback, now it is handled by clearing `setTimeouts`....

PR was updated. `master` was rebased. Conflicts were resolved. Failed tests were not impacted by this PR (for more information see https://github.com/openstreetmap/openstreetmap-website/pull/5439#issuecomment-2711306484).