scriptsdev icon indicating copy to clipboard operation
scriptsdev copied to clipboard

Work for satisfy recent Composer versions and a couple of features

Open ghost opened this issue 5 years ago • 2 comments

In Composer versions before composer/composer@599ad77167bc8cee895f024a20292689fd84153f the RootPackageInterface only defines a sub-set of operations needed by neronmoon/scriptsdev and RootAliasPackage only implemented those methods defined by the interface. Most of the unimplemented methods in RootAliasPackage can be worked around because the getter methods that are implemented proxy to the aliased package which we can modify by unwrapping.

ghost avatar Apr 16 '19 10:04 ghost

Thank you for your work! At this time i would like to keep plugin nice and small. So, please, avoid use of completely unnecessary external libraries. Or, at least, separate it into different PR.

Thank you

neronmoon avatar May 06 '19 06:05 neronmoon

Thank you for your work! At this time i would like to keep plugin nice and small. So, please, avoid use of completely unnecessary external libraries. Or, at least, separate it into different PR.

Thank you

Hello @neronmoon.

I know have added some geeky dependencies, there are some fancy messages too, have a workaround with all current tests ok and will remove those unnecessary user-dependencies, but there are some "generification" in code that don't know if you like it. Wants ready to merge/replace any section almost in same way that did before (plus remote support), but doing just for scripts if no extends.

You are welcome. Kind regards.

ghost avatar May 09 '19 19:05 ghost