gsplat icon indicating copy to clipboard operation
gsplat copied to clipboard

remove some magic numbers

Open YertleTurtleGit opened this issue 1 year ago • 2 comments

YertleTurtleGit avatar Apr 26 '24 10:04 YertleTurtleGit

I intended to keep these magic numbers as they corresponds exactly to the reference code from the original authors, so people can verify the correctness/consistency of the implementation. But I think a better way here is instead of replacing these magic numbers, add some comments like:

result[..., 0] = 0.2820947917738781 #  SH_C0

What do you think?

jb-ye avatar Apr 26 '24 18:04 jb-ye

I intended to keep these magic numbers as they corresponds exactly to the reference code from the original authors, so people can verify the correctness/consistency of the implementation. But I think a better way here is instead of replacing these magic numbers, add some comments like:

result[..., 0] = 0.2820947917738781 #  SH_C0

What do you think?

Hey, thanks for the early comment. Didn't expect that (: And regarding that: Makes sense. I'll handle that in the coming days if you don't mind. Cheers.

YertleTurtleGit avatar Apr 27 '24 05:04 YertleTurtleGit