Christian González comments

Results 165 comments of


                                            Christian González

ModelStream as Mixin?

> You make good points. Let me mull that over. Thanks. Ah, and: You could even keep the `ModelStream` classes. ```python class ModelStreamMixin: ... class ModelStream(ModelStreamMixin, Stream): pass class ModelStreamComponent(ModelStreamMixin,...

When group name is too long, don't raise TypeError

Oh, and the 99 characters are a bit, eh,. random? Why not 128?

When group name is too long, don't raise TypeError

Definitely better idea!

Jinja wordwrap wraps each character instead of word

ok, give me some time, plenty of work ATM.

Bower is deprecated and suggests moving to Yarn and Webpack or Parcel

@llazzaro Maybe you could split it into `django-scheduler-backend` and `django-scheduler-frontend`?

update radio_select_button_group widget to BS5

I'm so busy ATM I'm afraid I won't be able do that in the next months... sorry. No problems to just leave it open until I find time.

file "copyrigh" is created and produces lintian error

A CR (or CR/LF in Windows) is a line *terminator*, not a line *delimiter*. So the last line **should** be terminated by a CR. OTOH, lintian has a bad habit...

Missing function to get groups a user is "pending" member of.

nice idea.

Not possible to change field name shown on user/register page

Something to add: it **is** possible to change the _sort field_ - So I suppost most of the the code of this FR is already there. It would be just...

[WIP] High level mapping elements

This seems to looks very nice, thanks for this substantial code portion. Yes, this is the way I think the direction should go - the syntax you suggest is clear...