Christian González comments

Results 219 comments of


                                            Christian González

Use Django's "normal" validation, not hardcoded in init()

I'm afraid I don't find time ATM - if it works for you, just merge it, I will test it in a few weeks when it is easier, and reopen...

Use Django's "normal" validation, not hardcoded in init()

So, I tested the new behaviour a bit. The field now seems to validate the phone number correctly: it is done in the `validate_international_phone_number` validator. The only thing I have...

Use Django's "normal" validation, not hardcoded in init()

The only thing I can think of is: Be less strict. If you have a username check, the validator just checks if the username **generally** is correct. and in my...

Use Django's "normal" validation, not hardcoded in init()

> First thing, now that I know more about your use case, have you seen the [`region` argument to the form field](https://django-phonenumber-field.readthedocs.io/en/stable/reference.html#form-field)? It is meant to interpret numbers in a...

On tabler.io homepage/Alerts page, content was copied and is not adaequate to context.

@ajmalfaris11 - are you a bot? Your post doesn't add useful information here - it just repeats what I said in my issue description.

menus empty if generate_menu not called within same block.

I know a bit more now. See in an example here with a base.html: ```django {% load menu %} {% block menu_wrapper %} {% generate_menu %} {% endblock %} {%...

menus empty if generate_menu not called within same block.

AAARGH. Sorry for the spam. It's much easier... ```django {% load menu %} {% generate_menu %} {% block body %}{% endblock %} ``` I was blinded by the docs because...

Using `if_filled` with the built in `if`

What about {% if is_filled. %} As abbreviation? Would be easy to implementiert, and less verbose.

Using `if_filled` with the built in `if`

oh, slot names IMHO are "machine names" and should be tested against `.isidentifier()` in all cases. This also breaks thinks slightly, but is extremely easy to fix, and allows things...

Using `if_filled` with the built in `if`

As I happen to be the new maintainer of [Tetra](https://github.com/tetra-framework/tetra), I solved this problem there this way: https://github.com/tetra-framework/tetra/blob/d66db0caf54d756de5f44392235e7dba964973dd/tetra/templatetags/tetra.py#L266 This is straightforward, and works flawlessly by now.