Andrei Fajardo

Results 41 comments of Andrei Fajardo

> @nerdai, yes, it can. It depends on `openssl` though. Sorry @EricLBuehler not sure if I'm following. To my knowledge, Rust Toolchain is installed in our github runners by default...

@EricLBuehler we're getting close! Looks like tests are still failing. From the traceback captured in the logs, i see this: ``` ) -> list[dict[str, str]]: E TypeError: 'type' object is...

> @nerdai, that should be fixed now! Not sure why the tests I ran locally didn't catch that though. Happens to me too sometimes. I think there's a mismatch between...

@EricLBuehler time to 🛳️! Thanks for this :)

> > Thanks for the PR @AgenP. I have left some comments. I agree with you on RR / MRR, but I don't think that change is worth the breaking...

> Hey @nerdai, the iterations have been made! Here is a summary of the changes I've now implemented > > **MRR and HitRate changes** > > * `compute` method signatures...

> > Looks very good! I just think that maybe instead of using kwargs on `compute` to learn if we should use granular compute or not, maybe we just make...

@tos-wdp agreed this would be a worthwhile update. Would welcome a PR for this update, if you'd be interested in taking it on.

🤔`resume-screener-pack-test` is failing?