react-photo-gallery icon indicating copy to clipboard operation
react-photo-gallery copied to clipboard

Gallery layout is triggered when parent element is hidden (width=0)

Open cvolzke4 opened this issue 4 years ago • 1 comments

A re-layout of the photos happens when width is 0, ie. when the containing element is hidden. This causes the following problems:

  1. For an app with tabs, the scroll position of the gallery is not maintained when changing tabs.
  2. A complete re-layout is performed, which causes images to re-render causing flicker.

Screencast before: share.getcloudapp.com/2NuybPlb

Screencast with a fix: share.getcloudapp.com/6quebvrB

cvolzke4 avatar Sep 01 '20 10:09 cvolzke4

Feel free to ping me at [email protected] if you have any questions.

We'd like to use this in our Story Editor app.

PR: https://github.com/neptunian/react-photo-gallery/pull/184

cvolzke4 avatar Sep 02 '20 05:09 cvolzke4