neptune-client icon indicating copy to clipboard operation
neptune-client copied to clipboard

Support the cgroup v2 for hardware monitoring

Open mreto opened this issue 1 year ago • 1 comments

https://neptune-labs.atlassian.net/browse/NPT-12693 https://neptune-labs.atlassian.net/browse/NPT-12495

I have implemented support for cgroup v2. In order to test the solution I have run docker images on Ubuntu 20 (does support cgroupV1) and Ubuntu 22 (cgroupv2) virtual machines. Building automated tests on github would take some time, I have tried adding custom workflow with simple docker file, but it didn't really work and I would need more time to make it work. I was not sure if we even wanted this and if it's worth maintaining another build for a few tests. Let me know what you think

Before submitting checklist

  • [x] Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • [ ] Did you ask the docs owner to review all the user-facing changes?

mreto avatar Oct 18 '23 08:10 mreto

Codecov Report

Attention: 84 lines in your changes are missing coverage. Please review.

Comparison is base (8e74da9) 79.35% compared to head (3c54a3e) 73.10%. Report is 59 commits behind head on master.

Files Patch % Lines
...mon/hardware/cgroup/cgroup_v2_filesystem_reader.py 29.62% 38 Missing :warning:
...mon/hardware/cgroup/cgroup_v1_filesystem_reader.py 29.78% 33 Missing :warning:
...c/neptune/common/hardware/cgroup/cgroup_monitor.py 25.00% 9 Missing :warning:
...common/hardware/cgroup/cgroup_filesystem_reader.py 63.63% 4 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1532      +/-   ##
==========================================
- Coverage   79.35%   73.10%   -6.25%     
==========================================
  Files         291      293       +2     
  Lines       14811    14604     -207     
==========================================
- Hits        11753    10676    -1077     
- Misses       3058     3928     +870     
Flag Coverage Δ
e2e ?
e2e- ?
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
macos 72.78% <32.25%> (-6.54%) :arrow_down:
macos-latest ?
py3.10 ?
py3.7 73.07% <32.25%> (-6.01%) :arrow_down:
py3.7.16 ?
py3.8 ?
py3.9 ?
ubuntu 72.93% <32.25%> (-6.39%) :arrow_down:
ubuntu-latest ?
unit 73.07% <32.25%> (-0.82%) :arrow_down:
windows 72.24% <32.25%> (-7.11%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 18 '23 08:10 codecov[bot]