python-taiga icon indicating copy to clipboard operation
python-taiga copied to clipboard

Fix pagination

Open yakky opened this issue 4 years ago • 2 comments

Description

Page parameter was not passed to querystring, thus pagination failed

Ensure page parameter is actually passed to query parameters

References

Fix #116

Checklist

  • [x] I have read the contribution guide
  • [x] Code lint checked via inv lint
  • [x] changes file included (see docs)
  • [ ] Usage documentation added in case of new features
  • [x] Tests added

yakky avatar Oct 23 '21 09:10 yakky

Codecov Report

Merging #119 (a35adf2) into master (f448eda) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   96.34%   96.35%           
=======================================
  Files           8        8           
  Lines         876      878    +2     
  Branches       63       64    +1     
=======================================
+ Hits          844      846    +2     
  Misses         19       19           
  Partials       13       13           
Flag Coverage Δ
unittests 96.35% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
taiga/models/base.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f448eda...a35adf2. Read the comment docs.

codecov[bot] avatar Oct 23 '21 09:10 codecov[bot]

Coverage Status

Coverage increased (+0.005%) to 97.829% when pulling a35adf2708a9923c2d3e97ceec1624e9a2b62326 on bugfix/issue-116-fix-pagination into f448edabe872e2eb295550d75a1267a0c8f27a40 on master.

coveralls avatar Oct 23 '21 09:10 coveralls