django-meta icon indicating copy to clipboard operation
django-meta copied to clipboard

WiP: Add schema.org support

Open yakky opened this issue 6 years ago • 6 comments

Add schema.org by adding a separate set of data to handle it

As the schema.org standard keeps adding more type and properties, trying to map them would be pretty pointless: it would be too complicated to maintain.

Thus a leaner approach has been designed here: the developer has to create dictionaries of properties, with some syntactic sugar which automatically replaces Meta and ModelMeta instances with their schema to allow to easily build nested structures programmatically

  • [x] implementation
  • [x] documentation (but still needs validation)
  • [ ] tests

Fix #73

yakky avatar Apr 01 '18 09:04 yakky

Coverage Status

Coverage decreased (-2.07%) to 96.528% when pulling 34c455ad3f8cea795c40ff5b3fbf137500116eb9 on feature/schema.org into f068e21d1685c2adc58ef76048c3d3d140c50ca9 on develop.

coveralls avatar Apr 01 '18 16:04 coveralls

Coverage Status

Coverage decreased (-0.8%) to 97.588% when pulling 46a4396fb3929c669851d6e0799d6c4932ecaef7 on feature/schema.org into 1efae57740e03584af4caab05dd067911cfd3802 on develop.

coveralls avatar Apr 01 '18 16:04 coveralls

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.14 :warning:

Comparison is base (f5dfca7) 97.58% compared to head (46a4396) 97.45%.

:exclamation: Current head 46a4396 differs from pull request most recent head 1f40161. Consider uploading reports for the commit 1f40161 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #76      +/-   ##
===========================================
- Coverage    97.58%   97.45%   -0.14%     
===========================================
  Files            8        4       -4     
  Lines          456      118     -338     
  Branches        78       12      -66     
===========================================
- Hits           445      115     -330     
+ Misses           8        2       -6     
+ Partials         3        1       -2     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
meta/settings.py 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 01 '18 17:04 codecov[bot]

@yakky This feature would be useful. How could I help with this PR? Anything more than fixing/writing tests?

batisteo avatar Apr 18 '18 09:04 batisteo

I think that at this stage, the validation of the the API and the overall design is the most needed help Code contribution is obviously welcome, but having more eyeballs reviewing the code is obviously welcome The single most critical part is the serializer (or rather, the pre-serializer) https://github.com/nephila/django-meta/pull/76/files#diff-6cc6678cc74aae622c25042ad7e88fe0R197

yakky avatar Apr 18 '18 23:04 yakky

Would be great to have this implemented

khrizo avatar Jun 30 '20 16:06 khrizo

@yakky Can this feature be merged?

svandeneertwegh avatar May 13 '23 07:05 svandeneertwegh

@svandeneertwegh unfortunately it's a WIP I did not have the time to work on to finalize it Any help in validating the approach would be very warmly welcome

yakky avatar Jun 08 '23 20:06 yakky

@yakky I'll close this as it is superseded by #166 . @svandeneertwegh @khrizo this feature is now released on 2.4.0 version.

protoroto avatar Sep 25 '23 07:09 protoroto