neos-ui icon indicating copy to clipboard operation
neos-ui copied to clipboard

BUGFIX: Always bundle custom svgs instead of using `resource://` paths

Open mhsdesign opened this issue 1 year ago • 1 comments

Resolves: https://github.com/neos/neos-ui/issues/3616 Resolves: https://github.com/neos/neos-ui/issues/3712

See https://github.com/neos/neos-ui/issues/2092#issuecomment-2283775887 for an explanation

What I did

The custom icons are now included into the bundle instead of requested by path.

image

Also to unify things and simplify the build-stack, the Neos icon is now also bundled as plain svg instead of data-url:

image

Also the fallback image of the image editor will be fixed for cloud hosted resources now:

before after
image image

Surprisingly i could not observer any pixel shifting. So this should be 100% the same visual look.

How I did it

How to verify it

mhsdesign avatar Aug 08 '24 12:08 mhsdesign