neos-ui icon indicating copy to clipboard operation
neos-ui copied to clipboard

BUGFIX: Always bundle custom svgs instead of using `resource://` paths

Open mhsdesign opened this issue 1 year ago • 1 comments

Resolves: https://github.com/neos/neos-ui/issues/3616 Resolves: https://github.com/neos/neos-ui/issues/3712

See https://github.com/neos/neos-ui/issues/2092#issuecomment-2283775887 for an explanation

What I did

The custom icons are now included into the bundle instead of requested by path.

image

Also to unify things and simplify the build-stack, the Neos icon is now also bundled as plain svg instead of data-url:

image

Also the fallback image of the image editor will be fixed for cloud hosted resources now:

before after
image image

Surprisingly i could not observer any pixel shifting. So this should be 100% the same visual look.

How I did it

How to verify it

mhsdesign avatar Aug 08 '24 12:08 mhsdesign

As written in https://github.com/neos/neos-ui/issues/2092

Case (3.) is more complicated, I'm afraid. The <ResourceIcon/> is a specialization of the (unfortunately public API) <Icon/>-component. We will need to deprecate its behavior, and (prior to that) find a way to allow for custom Icon URIs that can be resolved on the server side (we'll some sort of configurable mapping thing here).

My idea is to deprecate the behaviour but thats just for us and without real effect obviously. To get rid of all usages we will - and i will plan do so - make the NodeTypeSchemaBuilder transform all resource:// paths on the server.

That will leave us with no more usages of client resource:// paths. Wdyt?

mhsdesign avatar Aug 12 '24 11:08 mhsdesign