neos-ui icon indicating copy to clipboard operation
neos-ui copied to clipboard

9.0 Remove DIRTY CODE `NodePropertyConverterService` and `NodePropertyConversionService`

Open mhsdesign opened this issue 2 years ago • 1 comments

Description

In the new ui we have such beautiful serialization logic - the neos ui should leverage it.

https://github.com/neos/neos-ui/blob/375b20ad77f8dacdb6d4f736568a31edda78c0ee/Classes/Domain/Service/NodePropertyConversionService.php

https://github.com/neos/neos-ui/blob/375b20ad77f8dacdb6d4f736568a31edda78c0ee/Classes/Domain/Service/NodePropertyConverterService.php was moved from Neos.Neos https://github.com/neos/neos-development-collection/blob/c480e239be07da98be4c4d7924f6cafd0200eb63/Neos.Neos/Classes/Service/Mapping/NodePropertyConverterService.php

[Description of the bug or feature]

Steps to Reproduce

  1. [First Step]
  2. [Second Step]
  3. [and so on...]

Expected behavior

[What you expected to happen]

Actual behavior

[What actually happened]

Affected Versions

Neos:

UI:

You can get this information by running composer show or using the package management module within Neos. The UI version can also be found inside the left sidebar after version 1.0.3.

mhsdesign avatar Sep 05 '23 07:09 mhsdesign

As said here comment

automatic forgiving property mapping (eg no exceptions but null in case of failure) is not desired

mhsdesign avatar Oct 20 '23 10:10 mhsdesign