neos-ui icon indicating copy to clipboard operation
neos-ui copied to clipboard

BUGFIX: Show resize icon on safari for document tree

Open Sebobo opened this issue 1 year ago • 9 comments

What I did

Both resize icons for the left sidebar are now visible (functionality was always there only invisible)

Resolves: #3556

How I did it

Removed the background color from the tree component itself and instead set the background colours of the parent component that define the resize option.

How to verify it

Check in all browsers whether the resize icons all properly show up.

Sebobo avatar Jul 13 '23 07:07 Sebobo

@crydotsnake can you give more details about your browser and version?

Sebobo avatar Jul 13 '23 08:07 Sebobo

@crydotsnake can you give more details about your browser and version?

Safari Version 16.5.1

crydotsnake avatar Jul 13 '23 08:07 crydotsnake

Ah thx, I can reproduce the issue when the window height is quite small. I will check. This fix doesn't make sense without fixing this too.

Sebobo avatar Jul 13 '23 08:07 Sebobo

I could make the resize work in safari, but the Icons are still pretty small, and it is no good UX to resize the trees in Safari. In other browsers, it still works fine.

markusguenther avatar Dec 16 '23 14:12 markusguenther

Ok, acceptance tests now also work :)

markusguenther avatar Dec 16 '23 20:12 markusguenther

Will test again

Sebobo avatar Dec 20 '23 10:12 Sebobo

I could make the resize work in safari, but the Icons are still pretty small, and it is no good UX to resize the trees in Safari. In other browsers, it still works fine.

But now the whole tree incl. the topbar scrolls? That's also wrong

Sebobo avatar Dec 20 '23 10:12 Sebobo

So I tried a few things. The main problem is that Safari uses a higher z-index for the scrollbar of the page tree subcomponent than for the resize icon of the parent container and they overlap. I tried the trick from https://stackoverflow.com/questions/21684101/css-vertical-scrollbar-padding-left-right-in-ul-possible but that didn't work properly either.

What works is to add a padding to leftSideBar__top which makes the icon work, but scrolling looks strange then... not sure if we can fix this without Safari being fixed 🤷🏻‍♂️

Sebobo avatar Dec 20 '23 10:12 Sebobo

Hi whats the status on this one? We found out that the autoprefixer for safari wasn't working so maybe this is related?

mhsdesign avatar Mar 13 '24 18:03 mhsdesign