BUGFIX: #3495 selectBoxHeaderWithSearchInput inputContainer has max-height

[gjwnc]

This PR fixes #3495 . Thanks to @Liioooo for finding and fixing the issue!
Tbh I don't actually understand why this fixes the bug, but I can confirm dimension switcher now works in chrome too.

How to verify it

Just open the dimension switcher with multiple languages in chrome and select a language

[gjwnc]

@crydotsnake I understand your very valid concerns. Our goal here was to get the dimension switcher to at-least work. E.g. the topic of the bug report #3495, was that the dimension switcher auto-closes itself in Chrome. And this PR fixes this.

What you described in your video is the current Neos 8.3 behaviour and this PR does not interfere with this afaik.
Imho, your concerns mentioned here should be moved in a separate bugreport. Everything you describe is current standard behaviour in NEOS 8.3 and is unrelated to this fix.
I think the current released dimension switcher is broken. And we tried to get it usable with this fix for all browser. So my suggestion is to apply this fix and maybe refactor the dimension switcher afterwards to fix your concerns.

[crydotsnake]

Hello @gjwnc

What you described in your video is the current Neos 8.3 behaviour and this PR does not interfere with this afaik. Imho, your concerns mentioned here should be moved in a separate bugreport.

The issues I mentioned in my comment above and which are also visible in my video, have only occurred with the changes of this pull request. Therefore, I think that my comments from above belong here in this pull request. 🙂

Everything you describe is current standard behaviour in NEOS 8.3 and is unrelated to this fix. I think the current released dimension switcher is broken. And we tried to get it usable with this fix for all browser.

That's not quite right. The dimension switcher only breaks, when more than 10 languages are configured. But for example with only 3 languages configured, the dimensions switcher behaves like usual in 8.3:

https://github.com/neos/neos-ui/assets/39345336/b259c67d-86e7-4700-b9dd-5fd9296b34d4

[crydotsnake]

Comparison

The dimension switcher only breaks, when more than 10 languages are configured.

https://github.com/neos/neos-ui/assets/39345336/e748a60c-2065-479b-b086-ab3befbfc8a7

[gjwnc]

To avoid confusion, I try to summarize the observations @crydotsnake mentioned from my perspective. It seems the behavior depends on browser and number of languages.

My and company team member observations are these: Given a project with more than 10 languages and without this PR and default Neos 8.3 UI we have the following

• language switcher can no longer be closed via the icon when it is unfolded This happens on all tested browser FF, Chrome, Brave and Safari
• moving the mouse over the language changes the width of the elements Also happens on all tested browser FF, Chrome, Brave, Safari
• magnifying glass icon is a little too close to the language switcher Same as above
• the language menu disappears on hover Happens only in Brave and Chrome on Ubuntu and Mac. This can be seen in Video 3 at second 23.

The last mentioned issue - which is the main problem - disappears on all tested browser for our project with the fix from this PR, that is adding max-height: 40px to .selectBoxHeaderWithSearchInput__inputContainer. This might be a hint on what is going on to someone else :shrug:
Since there are now a bunch of other issues mentioned here, you're right @crydotsnake, that this PR does not fix this all and this needs more time to fix.

I'm not able to fix the dimension switcher with everything mentioned because of lack of know-how in frontend dev.
@crydotsnake Maybe you could also elaborate on your setup Mac/Win/*nix or which browser you tested to get a better picture on what is working under which conditions and what not? And since I cannot fix this, I would suggest to comment in the original issue #3495 or creating a new one with more details?
What is very confusing to me is that, if I get you right, this PR is causing the disappearing behavior in Video 3 second 23 instead of fixing it, right? We have the exact opposite observations here.
How do we proceed with this PR and the issue itself?

[crydotsnake]

Closed since #3565 is merged.