neos-ui
neos-ui copied to clipboard
FEATURE: add ButtonEditor as new editor
Add new Neos.Neos/Inspector/Editors/ButtonEditor as described in #3474
@grebaldi i actually like to discuss the naming of the new editor. When i read "button editor" in the pr title i didnt really understand what the editor might do until i saw the screenshots. (I imagined 1 button which can be clicked or edited idk it didnt make sense in my head ^^)
maybe ChoiceEditor or something the like is better?
@grebaldi i actually like to discuss the naming of the new editor. When i read "button editor" in the pr title i didnt really understand what the editor might do until i saw the screenshots. (I imagined 1 button which can be clicked or edited idk it didnt make sense in my head ^^)
Look what I've put in the packages readme :-D

maybe
ChoiceEditoror something the like is better?
Yeah, I also wasn't really convinced by ButtonEditor.
But choice seems unconvincing too. Because selectbox or boolean editors are "choice editors" in some way?
Somehow it is a two state toggling editor but toggling many states...
Probably something like ToggleEditor or SwitchEditor? They can even be prefixed by List, Multiple, ... to clarify it? (ListToggleEditor)
@grebaldi thanks for your review. I'll update the PR soon. But https://github.com/neos/neos-ui/pull/3475#discussion_r1239679057 seems a bit blocking. The editor has to know the property type (currently by checking it's value) to commit the value?
I like ChoiceEditor. And in many cases it would probably replace the SelectBoxEditor used for a small list of values.
But https://github.com/neos/neos-ui/pull/3475#discussion_r1239679057 seems a bit blocking. The editor has to know the property type (currently by checking it's value) to commit the value?
Yeah, you're right. I this change isn't all that necessary. We can change this later on :)
@Sebobo proposed OptionsEditor
but we imo should avoid any naming confusion with our selectbox editor