neos-ui icon indicating copy to clipboard operation
neos-ui copied to clipboard

Minor type/comparison error in shortpath of the augmented editors `commit` function

Open mhsdesign opened this issue 2 years ago • 1 comments

https://github.com/neos/neos-ui/blob/6aa5c74e75e4813ffd798905811d099df30d5705/packages/neos-ui/src/Containers/RightSideBar/Inspector/InspectorEditorEnvelope/index.js#L56

transientValueRaw has the type:

type TransientValueRaw = { value: any }

and will never equal to the unpacked plain value variable

should be;

if (transientValueRaw.value === value 

im too afraid to change it ^^

mhsdesign avatar Jan 27 '23 09:01 mhsdesign

Actually this guard causes this bug: https://github.com/neos/neos-ui/issues/3652

Because the comparison will take effect if the transientValueRaw is undefined (at the beginning of the editing)

mhsdesign avatar Oct 23 '23 18:10 mhsdesign