neos-development-collection icon indicating copy to clipboard operation
neos-development-collection copied to clipboard

Published 20 hours ago • verified publisher icon neos

Make the ConvertUrisImplementation more extensible

Open neos-bot opened this issue 9 years ago • 4 comments

Jira issue originally created by user michael.gerdemann:

Convert the anonymous function to a normal method, so that the ConvertUrisImplementation is expandable via an aspect.

Jira-URL: https://jira.neos.io/browse/NEOS-1477

neos-bot avatar Aug 04 '15 12:08 neos-bot

@gerdemann was it about this line? https://github.com/neos/neos-development-collection/blob/d73870685dd94ff2b82b57484c3fa516b02583c9/Neos.Neos/Classes/Fusion/ConvertUrisImplementation.php#L96

its been a long time ^^ do you think it would still be helpful?

mhsdesign avatar Jul 18 '22 22:07 mhsdesign

Generally ConvertUrisImplementation could be better expandable

kitsunet avatar Jul 19 '22 07:07 kitsunet

see also https://github.com/neos/neos-development-collection/pull/3486

mhsdesign avatar Jul 19 '22 07:07 mhsdesign

I don't need that any more at the moment. But it might still be cool to be able to adjust it in case of doubt.

gerdemann avatar Jul 19 '22 12:07 gerdemann

closing if favor of https://github.com/neos/neos-development-collection/issues/3155

mhsdesign avatar Sep 17 '23 09:09 mhsdesign