neos-development-collection
neos-development-collection copied to clipboard
TASK: Raise doctrine/dbal version constraint
Neos adjustments for https://github.com/neos/flow-development-collection/pull/2637 Related https://github.com/neos/eventstore-doctrineadapter/pull/17
Upgrade instructions
Review instructions
Checklist
- [ ] Code follows the PSR-2 coding style
- [ ] Tests have been created, run and adjusted as needed
- [ ] The PR is created against the lowest maintained branch
- [ ] Reviewer - PR Title is brief but complete and starts with
FEATURE|TASK|BUGFIX - [ ] Reviewer - The first section explains the change briefly for change-logs
- [ ] Reviewer - Breaking Changes are marked with
!!!and have upgrade-instructions
~~This is technically ready but needs https://github.com/neos/flow-development-collection/pull/2637 merged before it can work.~~
No longer because we have upmerged the double compat from 8.4
Added a commit that should be dropped later which should turn the CI green to see as a real e2e check if we missed something in flow.
I call this fine for now, see comments regarding the linting problem.
ähhh @mhsdesign you forced pushed and it's broken now?
i dropped my CI hack commit as i think this is ready to merge
Right, flow too? then lets goooooo
Alright, I would carefully say this is fine now, whatever might still need adapting can be done as a follow up.
Lol the total diff has become kinda unreviewable with all the casing changes 😅 DbalException -> DBALException etc ... but thanks for not force pushing and putting it nicely in separate commits ... i think i can +1 the additional changes as well ... though i have a question to findAllIterator see flow
Well it's a PITA with that exception, I tried to just unify it to DBALException now, instead of doing it one by one because meh.
I think nothing in here is raelly a big change apart from the iterable result thing in the media repos...