neos-development-collection icon indicating copy to clipboard operation
neos-development-collection copied to clipboard

TASK: Raise doctrine/dbal version constraint

Open kitsunet opened this issue 1 year ago • 6 comments

Neos adjustments for https://github.com/neos/flow-development-collection/pull/2637 Related https://github.com/neos/eventstore-doctrineadapter/pull/17

Upgrade instructions

Review instructions

Checklist

  • [ ] Code follows the PSR-2 coding style
  • [ ] Tests have been created, run and adjusted as needed
  • [ ] The PR is created against the lowest maintained branch
  • [ ] Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • [ ] Reviewer - The first section explains the change briefly for change-logs
  • [ ] Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

kitsunet avatar Jun 23 '24 11:06 kitsunet

~~This is technically ready but needs https://github.com/neos/flow-development-collection/pull/2637 merged before it can work.~~

No longer because we have upmerged the double compat from 8.4

kitsunet avatar Jun 28 '24 07:06 kitsunet

Added a commit that should be dropped later which should turn the CI green to see as a real e2e check if we missed something in flow.

mhsdesign avatar Jun 30 '24 11:06 mhsdesign

I call this fine for now, see comments regarding the linting problem.

kitsunet avatar Jul 01 '24 11:07 kitsunet

ähhh  @mhsdesign you forced pushed and it's broken now?

kitsunet avatar Jul 04 '24 08:07 kitsunet

i dropped my CI hack commit as i think this is ready to merge

mhsdesign avatar Jul 04 '24 08:07 mhsdesign

Right, flow too? then lets goooooo

kitsunet avatar Jul 04 '24 08:07 kitsunet

Alright, I would carefully say this is fine now, whatever might still need adapting can be done as a follow up.

kitsunet avatar Jul 11 '24 08:07 kitsunet

Lol the total diff has become kinda unreviewable with all the casing changes 😅 DbalException -> DBALException etc ... but thanks for not force pushing and putting it nicely in separate commits ... i think i can +1 the additional changes as well ... though i have a question to findAllIterator see flow

mhsdesign avatar Jul 11 '24 12:07 mhsdesign

Well it's a PITA with that exception, I tried to just unify it to DBALException now, instead of doing it one by one because meh.

kitsunet avatar Jul 11 '24 12:07 kitsunet

I think nothing in here is raelly a big change apart from the iterable result thing in the media repos...

kitsunet avatar Jul 11 '24 12:07 kitsunet