neos-development-collection icon indicating copy to clipboard operation
neos-development-collection copied to clipboard

Published 20 hours ago • verified publisher icon neos

WIP: FEATURE: Rework CR CatchUp mechanism

Open bwaidelich opened this issue 1 year ago • 3 comments

related: #4746

WIP because:

  • [ ] Proper(er) mechanism to prevent multiple catchup runs (maybe integrate #4751)?
  • [ ] Mechanism to skip projections that are not up-to-date and don't trigger hooks on replay/individual catchup – (maybe integrate with #4992)
  • [x] needs to be properly coordinated with other pending PRs like #4993, #4980, #4979
  • [ ] update neos docs to not promote block see https://docs.neos.io/guide/contributing-to-neos/event-sourced-content-repository/blocking-until-a-command-is-executed and related

bwaidelich avatar Apr 11 '24 15:04 bwaidelich

This already looks very promising and I like the direction this is taking! What part is still missing / incomplete? Just the new catchup implementation, right?

nezaniel avatar Apr 21 '24 09:04 nezaniel

This already looks very promising and I like the direction this is taking!

Thanks for the feedback, appreciated!

What part is still missing / incomplete?

I added some more lines to the task list above

bwaidelich avatar Apr 21 '24 10:04 bwaidelich

i just merged 9.0 into your pr. A few notes from my side:

  • \ContentGraphTableNames::tableNamePrefix is now public again because its passed to the separate package DbalTools this makes ContentGraphTableNames::checkpoint obsolete as well ... should be adjusted
  • i started merging the .feature behat tests but at last i decided to just accept 9.0 as it was getting tedious. My assumption based on the features i have seen changed is that only the blocking part was removed. As discussed ill split this up into a separate pr either way.
    • -> https://github.com/neos/neos-development-collection/pull/5059
  • the (new - from the frankfurt sprint) shallow packages Neos.ContentRepositoryRegistry.DoctrineDbalClient Neos.ContentRepositoryRegistry.PostgresDbalClient seem to be now obsolete which is good imo (we have too much stuff first level for any new contributor. They should be removed.
  • Due to only having the CommandHandlingDependencies at hand we cannot pass the cr to publishEvents to block.

mhsdesign avatar May 17 '24 08:05 mhsdesign

Closing because most of this is obsolete and will be fixed with #5321

bwaidelich avatar Nov 09 '24 16:11 bwaidelich