neos-development-collection icon indicating copy to clipboard operation
neos-development-collection copied to clipboard

9.0 Odd `RebasableToOtherWorkspaceInterface` commands `AddDimensionShineThrough` and `MoveDimensionSpacePoint`

Open mhsdesign opened this issue 1 year ago • 1 comments

The commands AddDimensionShineThrough and MoveDimensionSpacePoint will implement the RebasableToOtherWorkspaceInterface via https://github.com/neos/neos-development-collection/pull/4708

but they are not interested about the wordspaceName unlike the other commands but still operate on the contentstream ids.

This is the reason for the quirky $targetContentStreamId in createCopyForWorkspace.

Both commands will be used for structure adjustments and MoveDimensionSpacePoint will be available via flow content:moveDimensionSpacePoint

Despite being a little quirky they are both declared public api, so it would be hard to fix their api after Neos 9

Proposal:

  • make them internal and fix them later and (and createCopyForWorkspace)
  • fix it now to operate only on workspaces

mhsdesign avatar Mar 14 '24 09:03 mhsdesign