TASK: Remove "internal" node properties

[kitsunet]

Provides a helper to access hidden status as well as renaming _hiddenInIndex to hiddenInMenu.

Fixes: #4208

[kitsunet]

unrelated errors 🤷

[bwaidelich]

unrelated errors 🤷

@kitsunet Fixed with #4924 and rebased

[ahaeslich]

You mentioned that there are follow-up todos for Neos UI?

Looking at this PR I noticed Neos.Seo may also need adjustments. So checking our codebase I see that:

• the legacy migration should rewrite hiddenInIndex to hiddenInMenu
• translations must use the new name
• the UI uses _hiddenInIndex
• there are comments referencing the prop
• our rector package needs adjustments
• Neos.Demo needs adjustments in fusion and with the exported content

[kitsunet]

Rector btw. is here https://github.com/neos/rector/pull/45

[kitsunet]

• [x] the legacy migration should rewrite hiddenInIndex to hiddenInMenu
• [x] translations must use the new name

[kitsunet]

These testfailures seem again unreltaed?

[kitsunet]

ok interesting, those tests are from a recently merged PR in 9.0, but why do they show up here given that they are not in my branch?

Note this is because we get the "merge" PR branch in tests that is actually a representation of 9.0 HEAD + this PR branch and not just plainly this PR branch.

[kitsunet]

FYI: Karsten said just renaming the labels should be fine.

[kitsunet]

Neos.Demo: https://github.com/neos/Neos.Demo/pull/192

[nezaniel]

I'd like to help here but can't get PHPStorm to detect the merge conflicts...

[kitsunet]

I can try to get it back on track, somehow I thought iut was long merged 🙈

[kitsunet]

neos-ui change: https://github.com/neos/neos-ui/pull/3735 this fixes disabled tag export as well

[nezaniel]

what parts are still missing here? All that I can see looks very nice already

[kitsunet]

what parts are still missing here? All that I can see looks very nice already

Nothing IMHO, it should all be merged please 😆

[mhsdesign]

Extracted everything i though this pr was originally meant to be into https://github.com/neos/neos-development-collection/pull/5015 and added the things i found missing.

This pr now is super slim and only addresses the hiddenInMenu part. @kitsunet i think we might need a better description yet (also maybe for the WHY we did this). Rector seems already to be adjusted: https://github.com/neos/rector/pull/45

Followups:

• [x] https://github.com/neos/Neos.Demo/pull/192
• [x] https://github.com/neos/neos-seo/pull/183
• [x] https://github.com/neos/neos-ui/pull/3735

[mhsdesign]

Okay i pushed a few commits adjusting fusion and documentation further. I think there are now no references left. This is now even more breaking as there is no fallback layer in Fusion thus we need a good upgrade instruction in the pr and maybe rector?

[kdambekalns]

This broke the XLIFF files, Weblate says Opening and ending tag mismatch: body line 4 and trans-unit, line 20, column 20 (<string>, line 20) for Neos.Neos/Resources/Private/Translations/*/NodeTypes/Document.xlf

[dlubitz]

Looks like to many </trans-unit> tags.

[kdambekalns]

Yep, exactly:

[mhsdesign]

Fyi we missed to include some followups in the beta10 and might also have to consider providing a core node migration or a snipped to be copied (especially looking at @ahaeslich and her project as well as the docs and @nezaniel starship?)

[ahaeslich]

Fyi we missed to include some followups in the beta10 and might also have to consider providing a core node migration or a snipped to be copied (especially looking at @ahaeslich and her project as well as the docs and @nezaniel starship?)

🤔 Did you discuss a core migration for this in a recent weekly? I'm undecided here ... How about all those users testing the beta releases?