neos-development-collection icon indicating copy to clipboard operation
neos-development-collection copied to clipboard

Published 20 hours ago • verified publisher icon neos

FEATURE: Added Tests for legacyMigration issue

Open pKallert opened this issue 1 year ago • 10 comments

Wrote tests for issue: #4504

Review instructions

For the nodeList I recreated the nodes as they exist on my local machine after following the steps here: https://github.com/neos/neos-development-collection/issues/4504#issuecomment-1735759814

The order of the nodes corresponds to the order on my local machine after running the command from the migration 'NodeDataLoader'. The resulting events also match the event order as created on my local machine after the migration.

I also added a working example with a smaller node pool to check if the code and migration works.

Checklist

  • [ ] Code follows the PSR-2 coding style
  • [ ] Tests have been created, run and adjusted as needed
  • [ ] The PR is created against the lowest maintained branch
  • [ ] Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • [ ] Reviewer - The first section explains the change briefly for change-logs
  • [ ] Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

pKallert avatar Nov 03 '23 12:11 pKallert