neos-development-collection icon indicating copy to clipboard operation
neos-development-collection copied to clipboard

FEATURE: Command for kickstarting a node migration

Open crydotsnake opened this issue 2 years ago • 2 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Description

It would be create to have a command for kickstarting a node migration: ./flow kickstart:nodemigration

Possible Solution

No response

crydotsnake avatar Sep 04 '22 08:09 crydotsnake

@mhsdesign The Neos.Kickstarter Package is inside the flow-development-collection :)

crydotsnake avatar Sep 04 '22 19:09 crydotsnake

Hi ;) @crydotsnake

i get the confusion ^^

but believe me the issue belongs here :P hear me out:

The Node Migrations are a part of the neos cms so flow is too low level. That way we can exclude the flow-development-collection already architecturally.

Now the question is, at what place the migration logic is implemented, to find the right spot for the kickstarter.

The command

./flow node:migrate ...

is found here: https://github.com/neos/neos-development-collection/blob/38a2d39868cc346926666ee4ce26b7c2e3e7f118/Neos.ContentRepository/Classes/Migration/Command/NodeCommandController.php#L76

And this is in the 'neos-development-collection'.


Also flows command line does something nice you wont expect: Its extensible by default. So while its true that Neos.Kickstarter is in the flow collection, other packages can also provide flow kickstart:* commands, just by creating a command-controller named KickstartCommandController. So Neos.Kickstarter KickstartCommandController is not even the true one and only flow kickstart:* command, they just get all merged ;)

Infact there is already a kickstart command you might now in the neos collection: https://github.com/neos/neos-development-collection/blob/38a2d39868cc346926666ee4ce26b7c2e3e7f118/Neos.SiteKickstarter/Classes/Command/KickstartCommandController.php#L24 This one provides kickstart:site

so lets close your dub in flow: https://github.com/neos/flow-development-collection/issues/2889

mhsdesign avatar Sep 04 '22 20:09 mhsdesign

Current status:

The functionallity has been implemented in the Neos.ContentRepository package.

crydotsnake avatar Feb 28 '23 11:02 crydotsnake