neos-development-collection icon indicating copy to clipboard operation
neos-development-collection copied to clipboard

Published 20 hours ago • verified publisher icon neos

[BUGFIX] FusionObjects: LazyProps expects object

Open erkenes opened this issue 4 years ago • 7 comments

LazyProps expects the Class object and not ComponentImplementation due to Class Configuration

What I did

I changed the Class-Names cause they are not correct in PHP 7.1.x and added PHPdoc-Comment

Checklist

  • [x ] Code follows the PSR-2 coding style
  • [x ] Tests have been created, run and adjusted as needed
  • [ ] The PR is created against the lowest maintained branch

erkenes avatar May 25 '20 08:05 erkenes

#2985

erkenes avatar May 25 '20 08:05 erkenes

Thanks this change also fixes a problem I had after an update.

Can you target the PR for Neos 5.2? Should be simply changeable.

Sebobo avatar Jun 03 '20 07:06 Sebobo

@mficzel can you take a look if this is correct?

Sebobo avatar Jul 01 '20 09:07 Sebobo

@hlubek Your opinion would be good on this aswell

mficzel avatar Jul 02 '20 08:07 mficzel

I know we discussed this and ended up not doing this now as we were not sure wether this would a good ides to have as an api. We thought about opening that up later with some real world experience and use cases.

What is your usecase for this? Does this fix a bug or enable something for you.

mficzel avatar Jul 02 '20 08:07 mficzel

I had errors without this after an update of a customer project. They didn't even have anything special really.

Sebobo avatar Jul 02 '20 09:07 Sebobo

This needs a rebase on 5.2.

Sebobo avatar Jul 02 '20 09:07 Sebobo