flow-development-collection
flow-development-collection copied to clipboard
!!! FEATURE: Dispatcher psr overhaul
This is breaking if you implemented your own ControllerInterface or overwrote or expect some of the api methods of the ActionController. We now use a direct pattern of f(ActionRequest) => PsrResponseInterface in more places. Adjusting existing controllers should be easy though. Additionally implementing your own dispatch loop (don't do this) will need adjustments.
We discourage to manipulate $this->response in controllers,
although it should still work fine in actions for now, please consider
other options.
class Dispatcher
{
public function dispatch(ActionRequest $request): ResponseInterface;
}
This is the main PR and it contains
- https://github.com/neos/flow-development-collection/pull/3232
- https://github.com/neos/flow-development-collection/pull/3294
Followup: https://github.com/neos/flow-development-collection/pull/3301 Resolves: https://github.com/neos/flow-development-collection/issues/3289
This change needs an accompanying adjustment to Neos to adjust the PluginImplementation as well as Modules: https://github.com/neos/neos-development-collection/pull/4738
Upgrade instructions
WIP Upgrade notes: https://github.com/neos/flow-development-collection/pull/3232#issuecomment-1913166370
Review instructions
Checklist
- [ ] Code follows the PSR-2 coding style
- [ ] Tests have been created, run and adjusted as needed
- [ ] The PR is created against the lowest maintained branch
- [ ] Reviewer - PR Title is brief but complete and starts with
FEATURE|TASK|BUGFIX - [ ] Reviewer - The first section explains the change briefly for change-logs
- [ ] Reviewer - Breaking Changes are marked with
!!!and have upgrade-instructions