flow-development-collection icon indicating copy to clipboard operation
flow-development-collection copied to clipboard

Published 20 hours ago • verified publisher icon neos

TASK: Deprecate `ControllerContext::getFlashMessageContainer`

Open mhsdesign opened this issue 1 year ago • 0 comments

Upgrade instructions

As AbstractController::addFlashMessage should be used to add FlashMessages rather than interacting with the container directly this deprecation should go unnoticed. If its required, one should use the FlashMessageService to get the container:

$this->flashMessageService->getFlashMessageContainerForRequest($this->request)
    ->addMessage($errorFlashMessage);

Review instructions

This pr should not be merged before targeting 9.0. See https://github.com/neos/flow-development-collection/pull/3232#issuecomment-1915676748 for explanation.

Checklist

  • [ ] Code follows the PSR-2 coding style
  • [ ] Tests have been created, run and adjusted as needed
  • [ ] The PR is created against the lowest maintained branch
  • [ ] Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • [ ] Reviewer - The first section explains the change briefly for change-logs
  • [ ] Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

mhsdesign avatar Jan 29 '24 22:01 mhsdesign