flow-development-collection icon indicating copy to clipboard operation
flow-development-collection copied to clipboard

Published 20 hours ago • verified publisher icon neos

Why is `Cookie::createFromRawSetCookieHeader` unused?

Open mhsdesign opened this issue 1 year ago • 1 comments

What about the Cookie::createFromRawSetCookieHeader(...) method? [...] Should we deprecate and remove it or try to make actual use of it (could be in a follow-up)?

This should be a minimal invasive change in order to be applied to all supported branches without too much risk. If Cookie::createFromRawSetCookieHeader() is not used I'd be happy about a follow up that deprecates/removes it for master

copied from https://github.com/neos/flow-development-collection/issues/2138#issuecomment-695209246

mhsdesign avatar Jan 28 '24 20:01 mhsdesign

christian wrote:

I would mid term want to get rid of the whole Cookie object or remodel it maybe? IDK, sure a DTO to make getCookieParams/withCookieParams a bit nicer to use would be great, but right now the cookie object stems from our own http implementation way back. So anything we can cut from it is a win IMHO 😂

mhsdesign avatar Feb 06 '24 12:02 mhsdesign